On 05/10/15(Mon) 09:57, Masao Uebayashi wrote: > CVSROOT: /cvs > Module name: src > Changes by: uebay...@cvs.openbsd.org 2015/10/05 09:57:27 > > Modified files: > sys/net : if.c if_ppp.c > sys/net80211 : ieee80211_pae_output.c > > Log message: > Count IFQ_ENQUEUE() failure as output drop.
This does not make any sense and contradict your previous diff. if_enqueue() returns an error and the callers increment if_oerror. > mpi@ prefers checking IFQ_ENQUEUE() error, and this matches that. It does not. You clearly didn't look at the content of IFQ_ENQUEUE() and don't care about design.
