On 05/10/15(Mon) 09:52, Masao Uebayashi wrote: > CVSROOT: /cvs > Module name: src > Changes by: uebay...@cvs.openbsd.org 2015/10/05 09:52:46 > > Modified files: > sys/net : if_bridge.c if_spppsubr.c if_vlan.c > sys/netinet : ip_carp.c > > Log message: > Don't count IF_DROP()'ed packets as if_oerrors too. > > mpi@ plans to clean-up IF_DROP()'s, but fix consistent use of it for now.
Consistent to what? This diff depends on the other one that increment the counters in if_start(). Sadly you're now turning this counters into and even more inconsistent mess. What does if_oerror is supposed to mean when should we increment it or not? This diff only creates confusion because it only deals with 25% of the tree.
