On Wed, Sep 21, 2016 at 09:19:26AM +0200, Jan Stary wrote: > On Sep 21 06:58:52, normalper...@yhbt.net wrote: > > > > commit ea4f3fb3c6de93e10786fbfc1cb1bdf9006bbcdb > > > > Author: Alexandre Ratchov <a...@caoua.org> > > > > Date: Tue Sep 20 22:00:40 2016 +0000 > > > > > > > > sndio: handle 24-bit samples properly on OpenBSD > > > > > > That's a bit misleading: it will properly handle > > > whatever bitwidth SoX asks for. The 24 vs 32 was > > > just the initiating problem. > > > > Oops. Can you propose a standalone commit message which > > I can copy and use directly? Thanks. > > I can't speak for Alex, but I suppose > "Ask OpenBSD's sndio to use bits_per_sample" > would be appropriate.
Agreed. Without this diff, the requested bits_per_sample (part of the encoding) was not taken into account: the code used the signal precision instead, which is not the same all the time. ------------------------------------------------------------------------------ _______________________________________________ SoX-devel mailing list SoX-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sox-devel
