On Tue, May 12, 2009 at 12:42:32PM -0400, Jeff Ortel wrote:
>
> PACKAGING
>
> The spacewalk-schema.spec was updated to package and install install / 
> upgrade scripts for
> both oracle and postgres.  The files are installed in:
>
> /etc/sysconif/rhn/oracle/
>   main.sql
>   spacewalk_0.4-spacewalk_0.5.sql
>   ...
>
> /etc/sysconif/rhn/postgres/
>   main.sql
>   spacewalk_0.4-spacewalk_0.5.sql
>   ...
>
> As you can see, the upgrade scripts are aggregated using blend just like the 
> install
> scripts.  Spacewalk::Setup and the spacewalk-schema-upgrade scripts need to 
> be updated to
> support the new directory structure and files names.  This work has been 
> started but still
> needs more work.  ** Milan, can you help with changes to 
> spacewalk-schema-upgrade?  Also,
> anyone know what the links are for in the upgrade directories?  Do we need 
> them?  Can they
> be created during RPM install?

You cannot aggregate upgrade scripts because other products (like
Satellite) might want to address individual upgrade scripts (via
symlinks, or, work-in-progress, via references). There is a reason we
kept the upgrade scripts separated.

As a matter of fact, I think that if would be good to have the main
schema definition (universe.satellite.sql, or main.sql) split into
individual source files as well -- basically just pack the source
files and concatenate them at install time. The reason is that it
would make schema overrides by Satellite schema package easier, and
upgrade scripts could just reference file name of new package or
function, rather than having the source code duplicated and
potentially out of sync.

So here I feel the move has been in the wrong direction.

-- 
Jan Pazdziora
Senior Software Engineer, Satellite Engineering, Red Hat

_______________________________________________
Spacewalk-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/spacewalk-devel

Reply via email to