Jan Pazdziora wrote:
On Tue, May 12, 2009 at 12:42:32PM -0400, Jeff Ortel wrote:
STYLE
You may notice that the common/tables/*.sql were formatted using chameleon.
Consistent with most DDL/SQL style guides, chameleon renders keywords in caps
and
uses spaces instead of tabs. If you don't like this style, don't freak out. We
take a vote and I can easily re-run the files through chameleon and reformat to
any style we like :-)
I'm against any reformating which is not supported by semantic
validation reasons, for reasons stated in previous posts -- it makes
the diff against master bigger and hides things from the naked eye.
We should not change the source code in the branch just because we
can or just because we have a tool to do that.
Note: I don't really care about the actual format, so I'm not voting
against the format per se (apart from the trailing spaces it seems to
introduce). We can put together some coding guidelines and use them
for new code.
I'm for the reformatting (our SQL is pretty inconsistent), though I'm
not sure if now is necessarily the best time. On one hand, I like the
idea of doing such sweeping changes all at once; it'll lead to the
codebase settling into its own sooner. On the other, since so much is
going on there's a fair risk something will be broken, so having easier
diffs while we shake out all the initial bugs might make life easier.
If it's still an option, I think my vote is to hold off on the
reformatting until after things have settled down a bit. I'm ok with
eventually having a big hiccup in diffs, but I think it's going to
complicate the initial pgsql bugs.
--
Jason Dobies
RHN Satellite / Spacewalk
RHCE# 805008743336126
Freenode: jdob @ #spacewalk #spacewalk-devel
_______________________________________________
Spacewalk-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/spacewalk-devel
