On 08/23/2011 06:26 PM, Bo Maryniuk wrote: > Entire Spacewalk components are going to be altered, where each > audit-able action will perform a call. We already developed an log4j > appender and now processing all Java part and XML-RPC backend and a > frontend. This will help community to reconnect audit to something
So you already have something. Can you send what you have, so we can review the implementation? It would be unfortunate if you send mega patch and we will do not like several items and reject it. It does not need to be polished or apply to current HEAD. And it does not need to be complete. Just to see the code behind your ideas. > The feature will be turned off by a default and will be able to turn > it on in a Spacewalk conf, like: "audit = on". Definitelly. Most users will not need this one, so it should be disabled by default. > Q: Why not just another log appender? > A: We believe it should be generic, agnostic and reliable. Hence > the embedded database and thread black magic are involved among other > things. :) This is where I disagree. But I would like to see your code and maybe I will change my mind. > Q: A daemon? > A: Yes. A daemon. Because if this would be a servlet on a Tomcat, so > once Tomcat "feels sour" during various reasons, like a star wars > satellite accidentally blew up WAN or endothermal recalibration caused > failure converting big to little endian, for example :-), then the rest > of the stack won't properly functioning. That should not happen. *nod* > Q: How fast the thing is? > A: 1000 messages linearly per 0.42 sec per instance should be enough. That is quite slow IMO for logger. > We are going to open it under Apache Licence 2.0 and contribute back to > the community along with a mega-patch for Spacewalk 1.2 base. Please no mega-patch. And definitelly no unless you send few iteration of what-you-have patch, so we can review and discuss whether it is good approach or not. This is thing which can be done good and be great benefit, but with only few things screwed can slow down whole Spacewalk even in disabled state. -- Miroslav Suchy Red Hat Satellite Engineering _______________________________________________ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
