On 08/25/2011 05:43 PM, Miroslav Suchý wrote:
AuditLog.java has 4 (!) functions log() and all of them has different semantics - if I ommit that they are utilized to logging. Please consider different names.
Four? Functions?.. I see three and they are methods, where only one is public. This is called overloading and was around for a few decades... Why you dislike that part? > In your design it will be hard to say which actions are audited. > Especially in 2 years from now, when other will add/remove/change your > initial audit calls. I thought the patches reviews you, guys, doing are more than just works/not-works? :) Generic approach is exactly what we already tried to do at the very beginning. -- Bo Maryniuk SUSE LINUX Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer HRB 16746 (AG Nürnberg) _______________________________________________ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
