On 05/15/2012 09:29 PM, Miroslav Suchy wrote: > On 15.5.2012 14:28, Johannes Renner wrote: >> On 05/15/2012 01:25 PM, Miroslav Suchy wrote: >>> +Requires: susestudio-java-client >>> >>> This will require susestudio-java-client rpm? It is not present in neither >>> in Fedora nor in >>> jpackage. >>> Can I take: >>> >>> https://build.opensuse.org/package/view_file?file=susestudio-java-client.spec&package=susestudio-java-client&project=Java%3Abase&rev=3acd29dcce3b7fe9fad7c42e11358e75 >>> >>> >>> or you have some recent spec? >> >> I just checked it again: yes, please take it from there. This is the most >> recent specfile >> and sources. In case you don't have the other required package in Fedora or >> jpackage >> (simple-xml), you can get it from here as well: >> >> https://build.opensuse.org/package/show?package=simple-xml&project=Java%3Abase >> >> Thanks, >> Johannes >> > > OK, I started with simple-xml. It sucessfully build on all supported > platforms. Thats good. > > Can you fix these warnings and errors of rpmlint:
Ok, I committed some changes to the spec, please see my comments below + the changes itself: https://build.opensuse.org/package/rdiff?linkrev=base&package=simple-xml&project=Java%3Abase&rev=3 > simple-xml.src: E: description-line-too-long C Simple is a high performance > XML serialization and > configuration framework for Java. I shortened the description lines to < 79 characters. > simple-xml.src: W: non-standard-group Development/Libraries/Java Please assign whatever group is valid for Fedora/RedHat, since "Development/Libraries/Java" is just the right group to be used for SUSE. I guess we could have some "%if (0%?rhel/?suse_version) %else ..." though, if you prefer that. > simple-xml.src: E: no-changelogname-tag > ^^^^ this one can be ignored as first build with tito will fix it. Good, since we usually maintain those changelogs in separate .changes files. > simple-xml.src: W: invalid-license Apache-2.0 Same as above: please edit it and set the Fedora equivalent for your needs. If I change it, OBS will print a warning, since Apache-2.0 is the correct license string for SUSE. According to http://fedoraproject.org/wiki/Licensing you might have to put "ASL 2.0". > simple-xml.src:53: W: setup-not-quiet No idea about that one, OBS doesn't print that warning. I added -q to %setup, HTH. > simple-xml.src: W: invalid-url Source0: simple-xml-2.6.2.zip Fixed that and put a URL. Not a valid one though, since download URLs are dynamically generated for this project that is hosted on sourceforge. > And I see that upstream has new version: 2.6.3. Can you rebase to it? Is just > version bump > sufficient or spec needs more changes? The new version seems to build just fine, so I rebased the package. Thank you, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer _______________________________________________ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
