Hello Edouard,
> The changes may show up in the anonymous cvs soon[1].
They finally did. I see in the changelog says "Checks for
frames that are too long.", but that part you actually dropped.
Against the current pppoa3.c the following minor cleanups
could be applied:
$ diff -pu pppoa3.c.000 pppoa3.c
--- pppoa3.c.000 Thu Nov 20 13:57:12 2003
+++ pppoa3.c Thu Nov 20 14:09:54 2003
@@ -1002,10 +1002,10 @@ static void *read_from_usb_thread(void*
int n;
int pti;
int num_bytes_new;
- unsigned char lbuf[64*53];
+ unsigned char lbuf[64 * ATM_CELL_TOTAL_SIZE];
unsigned char *unused_cells;
- /* Reads 64*53 bytes from usb */
+ /* Reads 64 * ATM_CELL_TOTAL_SIZE bytes from usb */
do {
n = pusb_endpoint_read(ep_data, lbuf, sizeof(lbuf), 0);
} while (n < 0 && (errno == EINTR || errno == ETIMEDOUT));
@@ -1071,8 +1071,7 @@ static void *read_from_usb_thread(void*
nb_cells = pos / ATM_CELL_DATA_SIZE;
/* calculate the rest if there is any */
- num_bytes_new = num_bytes_read -
nb_cells*ATM_CELL_TOTAL_SIZE;
- num_bytes_read -= nb_cells*ATM_CELL_TOTAL_SIZE;
+ num_bytes_new = num_bytes_read -= nb_cells *
ATM_CELL_TOTAL_SIZE;
/* Reset the frame position */
pos = 0;
--- end of patch ---
That about covers it. By the way, thanks for accepting the patch.
Bye,
Leonard.
--
How clean is a war when you shoot around nukelar waste?
Stop the use of depleted uranium ammo!
End all weapons of mass destruction.
Liste de diffusion modem ALCATEL SpeedTouch USB
Pour se d�sinscrire : mailto:[EMAIL PROTECTED]
