Not RowCreateSignal (called before insert, allowing modification of kwargs) but
RowCreatedSignal (called after insert).

It is currently defined as (kwargs, post_funcs), but never calls post_funcs and
would make a lot more sense to send the newly created instance. The docs suggest
there may also be a connection argument, which combined with the 'class' and
'id' keys in kwargs would allow you to retrieve the newly created instance, but
in fact connection is never passed.

If there are no objections, I would vote that it be redefined to match
RowUpdateSignal in taking (inst, kwargs). Alternatively it could just go away,
as RowCreateSignal's post_funcs handle the scenario, but it seems clearer to say
"I'm only interested in the new instances that are created", not in effecting
the creation of new instances and/or post-processing.

I'm also considering adding a RowUpdatedSignal, for the same reasons, although
depending on people's feelings about the above 'post_funcs' could be added to
RowUpdateSignal instead.

- Luke


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
sqlobject-discuss mailing list
sqlobject-discuss@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sqlobject-discuss

Reply via email to