----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2983/#review3599 -----------------------------------------------------------
Thanks for the patch Bilung. I have a few general comments: 1. Since the new mechanism for build switch between 20 and 23 overwrites the ivy.xml file which is inside source control, it can possibly cause confusion when a build is done. One way to fix this would be to remove top level ivy.xml from source control, put top level ivy.xml in svn:ignore property, and the always copy the appropriate ivy-hdpXX.xml file during build. 2. It would be great if we can use the hadoop version property to selectively exclude tests from running when the 23 version is used. Doing this will make sure that the tests continue to run when the build is done against 20. - Arvind On 2011-12-01 18:59:33, Bilung Lee wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2983/ > ----------------------------------------------------------- > > (Updated 2011-12-01 18:59:33) > > > Review request for Sqoop, Arvind Prabhakar and Tom White. > > > Summary > ------- > > Make Sqoop work with Hadoop 0.23 > > > This addresses bug SQOOP-397. > https://issues.apache.org/jira/browse/SQOOP-397 > > > Diffs > ----- > > ./COMPILING.txt 1197706 > ./build.xml 1208854 > ./ivy.xml 1208716 > ./ivy/libraries.properties 1208716 > ./src/ivy/ivy-hdp20.xml PRE-CREATION > ./src/ivy/ivy-hdp23.xml PRE-CREATION > ./src/ivy/libraries-hdp20.properties PRE-CREATION > ./src/ivy/libraries-hdp23.properties PRE-CREATION > ./src/test/com/cloudera/sqoop/TestCompression.java 1208716 > ./src/test/com/cloudera/sqoop/hbase/HBaseTestCase.java 1208054 > ./src/test/com/cloudera/sqoop/hbase/TestHBaseImport.java 1208054 > ./src/test/com/cloudera/sqoop/hbase/TestHBaseQueryImport.java 1208054 > ./src/test/com/cloudera/sqoop/mapreduce/db/TestDataDrivenDBInputFormat.java > 1208054 > > Diff: https://reviews.apache.org/r/2983/diff > > > Testing > ------- > > > Thanks, > > Bilung > >
