----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2983/#review3600 -----------------------------------------------------------
./COMPILING.txt <https://reviews.apache.org/r/2983/#comment8025> I think 0.20.x should continue to be the default until 0.23.x has stabilized. ./build.xml <https://reviews.apache.org/r/2983/#comment8026> Rather than using conditional logic in the build, it would be simpler to use the approach that Pig takes and drive the choice by a property. Search for "hadoopversion" in http://svn.apache.org/repos/asf/pig/trunk/build.xml and http://svn.apache.org/repos/asf/pig/trunk/ivy.xml (note the way the configuration name is parameterized in the latter). ./ivy/libraries.properties <https://reviews.apache.org/r/2983/#comment8027> We should parameterize HBase at the same time so we can switch to 0.92.0 when it comes out, since it supports Hadoop 0.23. ./ivy/libraries.properties <https://reviews.apache.org/r/2983/#comment8028> ZooKeeper too? ./src/test/com/cloudera/sqoop/hbase/HBaseTestCase.java <https://reviews.apache.org/r/2983/#comment8029> Rather than commenting out, why not just add an @Ignore annotation? Also open a JIRA and link to it so it doesn't get forgotten. - Tom On 2011-12-01 18:59:33, Bilung Lee wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2983/ > ----------------------------------------------------------- > > (Updated 2011-12-01 18:59:33) > > > Review request for Sqoop, Arvind Prabhakar and Tom White. > > > Summary > ------- > > Make Sqoop work with Hadoop 0.23 > > > This addresses bug SQOOP-397. > https://issues.apache.org/jira/browse/SQOOP-397 > > > Diffs > ----- > > ./COMPILING.txt 1197706 > ./build.xml 1208854 > ./ivy.xml 1208716 > ./ivy/libraries.properties 1208716 > ./src/ivy/ivy-hdp20.xml PRE-CREATION > ./src/ivy/ivy-hdp23.xml PRE-CREATION > ./src/ivy/libraries-hdp20.properties PRE-CREATION > ./src/ivy/libraries-hdp23.properties PRE-CREATION > ./src/test/com/cloudera/sqoop/TestCompression.java 1208716 > ./src/test/com/cloudera/sqoop/hbase/HBaseTestCase.java 1208054 > ./src/test/com/cloudera/sqoop/hbase/TestHBaseImport.java 1208054 > ./src/test/com/cloudera/sqoop/hbase/TestHBaseQueryImport.java 1208054 > ./src/test/com/cloudera/sqoop/mapreduce/db/TestDataDrivenDBInputFormat.java > 1208054 > > Diff: https://reviews.apache.org/r/2983/diff > > > Testing > ------- > > > Thanks, > > Bilung > >
