I'm not sure how uninterruptible the process is ... but ... the count of
outstanding downloads is decremented before the checksum is calculated
and compared ... and I think the restart prompt arrives between 0 and 2
seconds after the count reaches 0 (might be minimum 2 rather than 0 ...
not sure).
So - a big plugin that takes a long time to do the checksum comparison
along with a trigger happy user who clicks "restart" as soon as it
appears could be a way to shutdown LMS before it has finished doing its
processing so it would not know to complete the install on restart.
Perhaps the decrement of the "$downloading" variable should come later
... and in particular after
Code:
--------------------
$prefs->set($name, 'needs-install');
--------------------
(would need to be a bit further down to cover the if/then/else - in sub
_downloadDone in Slim/Utils/PluginDownloader.pm
Seems very narrow case though
Paul Webster
http://dabdig.blogspot.com
author of \"now playing\" plugins covering radio france (fip etc), kcrw,
supla finland, abc australia, cbc/radio-canada and rte ireland
------------------------------------------------------------------------
Paul Webster's Profile: http://forums.slimdevices.com/member.php?userid=105
View this thread: http://forums.slimdevices.com/showthread.php?t=112241
_______________________________________________
Squeezecenter mailing list
[email protected]
http://lists.slimdevices.com/mailman/listinfo/squeezecenter
