bpa wrote:
> No I had hoped to get to it but ... you may know the phrase "Men Plan
> and God Laughs"
Yes. :D
Paul Webster wrote:
> I'm not sure how uninterruptible the process is ... but ... the count of
> outstanding downloads is decremented before the checksum is calculated
> and compared ... and I think the restart prompt arrives between 0 and 2
> seconds after the count reaches 0 (might be minimum 2 rather than 0 ...
> not sure).
>
> So - a big plugin that takes a long time to do the checksum comparison
> along with a trigger happy user who clicks "restart" as soon as it
> appears could be a way to shutdown LMS before it has finished doing its
> processing so it would not know to complete the install on restart.
>
> Perhaps the decrement of the "$downloading" variable should come later
> ... and in particular after
> >
Code:
--------------------
> >
> $prefs->set($name, 'needs-install');
>
--------------------
> >
> (would need to be a bit further down to cover the if/then/else - in
> sub _downloadDone in Slim/Utils/PluginDownloader.pm
>
> Seems very narrow case though
I had a look at this again:
Code:
--------------------
[20-05-17 23:10:26.8711] Slim::Utils::PluginDownloader::install (163) install
- downloading RaopBridge from
http://downloads.sourceforge.net/project/lms-plugins-philippe44/RaopBridge-0.4.23.0.zip
[20-05-17 23:12:14.1969] Slim::Utils::PluginDownloader::_downloadDone (180)
downloaded RaopBridge to
/share/CACHEDEV1_DATA/.qpkg/LogitechMediaServer/SlimServer/Cache/DownloadedPlugins/RaopBridge.zip
[20-05-17 23:12:14.5319] Slim::Utils::PluginDownloader::_downloadDone (200)
digest does not match
/share/CACHEDEV1_DATA/.qpkg/LogitechMediaServer/SlimServer/Cache/DownloadedPlugins/RaopBridge.zip
- RaopBridge will not be installed: expected
1f6d91f22845a272a0f51eb26c75709618b528c7, got
b3dc5595762c57dbee32fcc291ff7e2d8da92cb3
[20-05-17 23:12:14.5325] Slim::Utils::PluginDownloader::_downloadDone (208)
Moving downloaded file for you to investigate:
from:
/share/CACHEDEV1_DATA/.qpkg/LogitechMediaServer/SlimServer/Cache/DownloadedPlugins/RaopBridge.zip
to:
/share/CACHEDEV1_DATA/.qpkg/LogitechMediaServer/SlimServer/Cache/RaopBridge-b3dc5595762c57dbee32fcc291ff7e2d8da92cb3.zip
--------------------
"downloadDone (180)" I'm still convinced that the download was not done
as it was still at 9 MB when I clicked "Restart now". I watched it
live.
Is there ANY way the download could have just merrily continued AFTER it
was moved and renamed? I ask because I just checked that file here:
/share/CACHEDEV1_DATA/.qpkg/LogitechMediaServer/SlimServer/Cache/RaopBridge-b3dc5595762c57dbee32fcc291ff7e2d8da92cb3.zip
myself. Along with the other discarded files, its download completed,
and the checksums of each and every one of them matches. And that file's
change date says 23:14. :confused:
QLMS [email protected] x64 (digimaster) with perl 5.30.1 / QNAP 469L QTS 4.3.4
------------------------------------------------------------------------
dolodobendan's Profile: http://forums.slimdevices.com/member.php?userid=67663
View this thread: http://forums.slimdevices.com/showthread.php?t=112241
_______________________________________________
Squeezecenter mailing list
[email protected]
http://lists.slimdevices.com/mailman/listinfo/squeezecenter
