fredposner left a comment (kamailio/kamailio#4800)
> IMHO, this slop PR should be closed out of hand for being slop. The cognitive
> burden of reviewing should not be born by the project.
>
> Practically, there is way too much going on here. This is a very significant
> and invasive change, even if it is, strictly speaking, additive. If one
> wanted to approach this in a way that does not vandalise the project with
> slop, one would likely make a feature branch, proceed in small feedback
> loops, and request intermediate review throughout those steps, along with
> validation that new constructs adhere to the norms, vocabulary, conventions
> and culture of the existing code base.
>
> It's hard work, and it takes time. If the author doesn't want to do it, I
> don't think we need to accept this slop.
I think this is a little harsh, especially considering @space88man is part of
the dev team and also introduced this in an email as well as his past
contributions to TLS and the project. I understand the current bias, but
believe this comment is unwarranted.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4800#issuecomment-4855645692
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4800/[email protected]>
_______________________________________________
Kamailio - Development Mailing List -- [email protected]
To unsubscribe send an email to [email protected]
Important: keep the mailing list in the recipients, do not reply only to the
sender!
