henningw left a comment (kamailio/kamailio#4800)
> Good (if some startling) feedback here - food for thought indeed. I think it
> makes more sense for me to close this PR as is . Let me tilt at my windmill
> again in another PR where the intent and design is more transparent. This
> branch will not go away soon so you can try the "reactor" mode if you are
> curious: just remember `tcp_main_threads = 2`. A new PR will be based off a
> more palatable sequence of commits.
Thank you @space88man. Your work on improving Kamailio is appreciated. One
requirement for acceptance for a PR (for me) is that the author is able to
explain why the change is necessary like this and how it works. This needs to
be done in his or her own words. Just pasting 4 pages of LLM generated text
description into a PR does not show this understanding to me.
Looking forward to your next contribution.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4800#issuecomment-4858252268
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4800/[email protected]>
_______________________________________________
Kamailio - Development Mailing List -- [email protected]
To unsubscribe send an email to [email protected]
Important: keep the mailing list in the recipients, do not reply only to the
sender!
