On Wed, Feb 27, 2013 at 09:48:32AM -0500, Simo Sorce wrote: > On Mon, 2013-02-25 at 11:11 +0100, Sumit Bose wrote: > > On Sat, Feb 23, 2013 at 07:20:36AM -0500, Simo Sorce wrote: > > > > > > > > > > Hi, > > > > > > > since we are creating a plugin interface, we should use custom > > > > > > > data > > > > > > > type in _recv instead of struct ares_srv_reply. > > > > > > > > > > > > makes sense. Then I would suggest that a list ordered according > > > > > > to RFC > > > > > > 2782 of hostname, port pairs is returned, where the elements then > > > > > > can be > > > > > > fed directly to create_fo_server(). Do you agree? > > > > > > > > > > For SRV records the RFC 2782 makes sense for sure, but is it also > > > > > applicable > > > > > to the AD site discovery? > > > > > > > > yes, since it is alse a SRV request. But there might be other > > > > environments where this is different, that's why I think it make > > > > sense > > > > to let the plugin return the list in a appropriate order. > > > > > > Maybe we should use an opaque structure private to the plugin > > > and then provide getters and setters ? > > > > Sorry, I cannot follow, getters and setters for what? > > For the results.
This might be useful if the fail-over logic is re-designed, but I think it is not needed in the current state. bye, Sumit > > Simo. > > -- > Simo Sorce * Red Hat, Inc * New York > > _______________________________________________ > sssd-devel mailing list > sssd-devel@lists.fedorahosted.org > https://lists.fedorahosted.org/mailman/listinfo/sssd-devel _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel