URL: https://github.com/SSSD/sssd/pull/106
Title: #106: Add a new "files" provider

pbrezina commented:
"""
So far it looks good and I have only very few comments. I didn't read the code 
thoroughly yet.

*NSS: Skip disabled domains during requests*
Rename to cache_req: please, because the change is there and not in nss 
responder.

*RESPONDER: A sbus interface to reset negatively cached users*
*DP: Add internal DP interface to enable and disable domains*
I will look how much work would it be to implement signals. I believe most of 
the work has been done already so if we can finish it rather quickly, we should 
do it right.

*CONFDB: Make pwfield configurable per-domain*
Can you move 'nss_get_pwfield' into nss_util.c? It doesn't really have anything 
common with protocol.

*CONFDB: The files domain defaults to "x" as pwfield*
Are we also able to authenticate with pam_sss without pam_unix?

*FILES: Add the files provider*
You say that a domain is disabled during enumeration and we fall back to nss 
files. Do you expect the update to take a really long time? Wouldn't it be 
better to jus wait until the enumeration is done?

"""

See the full comment at 
https://github.com/SSSD/sssd/pull/106#issuecomment-271260823
_______________________________________________
sssd-devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to