URL: https://github.com/SSSD/sssd/pull/143 Title: #143: Explicitly add ordering dependency for the responders' sockets
fidencio commented: """ On Tue, Feb 28, 2017 at 9:47 PM, Jakub Hrozek <[email protected]> wrote: > On Tue, Feb 28, 2017 at 07:51:26AM -0800, fidencio wrote: > > On Tue, Feb 28, 2017 at 4:25 PM, lslebodn <[email protected]> > wrote: > > > > > On (28/02/17 04:27), Jakub Hrozek wrote: > > > >I tested the patches both during the VM operation bringing different > > > responders up and during system boot. I haven't see any issues. > > > > > > > > > > A tiny question. > > > Do we need to add After to all sockets? > > > The ideal would be that socket will trigger starting of responder > > > and monitor will be started as a dependency of responder. > > > > > > I thought it is required just for nss due to some circular dependency. > > > > > > I would appreciate explanation. So if someone decide to remove it in > future > > > he will consider problematic use-case. > > > > > > > Lukáš, > > > > That was a recommendation of Lukáš Nykrýn that BindsTo and After must go > > together. It's mentioned in the commit message. > > Lukáš Nykrýn also mentioned they will fix their docs about this. > > I think Lukas was asking about something else -- would it be enough to > only add those changes to the nss socket file? I've talked to Lukáš on the office before replying the email :-) Anyways, no, it won't be enough. BindsTo and After *must* *go* *together*. We use BindsTo on all services' sockets and not using After as well may lead to unexpected behaviour. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/SSSD/sssd/pull/143#issuecomment-283155833>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AAG4ekmc6BgOlXlv7YWf66QmyxbNv09kks5rhIfvgaJpZM4L3N4p> > . > """ See the full comment at https://github.com/SSSD/sssd/pull/143#issuecomment-283158870
_______________________________________________ sssd-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]
