On Wed, Apr 13, 2011 at 8:51 AM, Greg KH <[email protected]> wrote:
> +
> + /*
> + * nr_pages for one entry is limited to
> (UINT_MAX>>PAGE_SHIFT)+1,
> + * so tot_pages cannot overflow without first going negative.
> + */
> + if ((int)nr_pages < 0)
> + ret = -EINVAL;
> + goto out;
> }
Yeah, what the heck happened there. That won't work.
As Paul says, the original was just a "return -EINVAL", and when the
backport changed it into a "ret = " + "goto out", it really needs a
couple of braces.
As it is, the patch is just broken. Think about it.
Linus
_______________________________________________
stable mailing list
[email protected]
http://linux.kernel.org/mailman/listinfo/stable
