On Fri, Apr 15, 2011 at 10:10:13AM -0700, Linus Torvalds wrote: > On Wed, Apr 13, 2011 at 8:51 AM, Greg KH <[email protected]> wrote: > > + > > + /* > > + * nr_pages for one entry is limited to > > (UINT_MAX>>PAGE_SHIFT)+1, > > + * so tot_pages cannot overflow without first going > > negative. > > + */ > > + if ((int)nr_pages < 0) > > + ret = -EINVAL; > > + goto out; > > } > > Yeah, what the heck happened there. That won't work. > > As Paul says, the original was just a "return -EINVAL", and when the > backport changed it into a "ret = " + "goto out", it really needs a > couple of braces. > > As it is, the patch is just broken. Think about it.
Ah crap, that's my fault, I did the backport totally wrong here. I'll fix this up and push an updated version out in a few hours when I get back from my daughter's earth-day field trip... thanks, greg k-h _______________________________________________ stable mailing list [email protected] http://linux.kernel.org/mailman/listinfo/stable
