On Mon, May 30, 2011 at 08:26:22AM +0800, [email protected] wrote: > > This is a note to let you know that I've just added the patch titled > > mtd: return badblockbits back > > to the 2.6.33-longterm tree which can be found at: > > http://www.kernel.org/git/?p=linux/kernel/git/longterm/longterm-queue-2.6.33.git;a=summary
And I've dropped it as it causes the following build error: drivers/mtd/nand/nand_base.c: In function ‘nand_get_flash_type’: drivers/mtd/nand/nand_base.c:2704:6: error: ‘struct nand_chip’ has no member named ‘badblockbits’ thanks, greg k-h > > The filename of the patch is: > mtd-return-badblockbits-back.patch > and it can be found in the queue-2.6.33 subdirectory. > > If you, or anyone else, feels it should not be added to the 2.6.33 longterm > tree, > please let <[email protected]> know about it. > > > >From 26d9be11485ea8c1102c3e8eaa7667412eef4950 Mon Sep 17 00:00:00 2001 > From: Artem Bityutskiy <[email protected]> > Date: Thu, 28 Apr 2011 20:26:59 +0300 > Subject: mtd: return badblockbits back > > From: Artem Bityutskiy <[email protected]> > > commit 26d9be11485ea8c1102c3e8eaa7667412eef4950 upstream. > > In commit c7b28e25cb9beb943aead770ff14551b55fa8c79 the initialization of > the backblockbits was accidentally removed. This patch returns it back, > because otherwise some NAND drivers are broken. > > This problem was reported by "Saxena, Parth <[email protected]>" here: > http://lists.infradead.org/pipermail/linux-mtd/2011-April/035221.html > > Reported-by: Saxena, Parth <[email protected]> > Signed-off-by: Artem Bityutskiy <[email protected]> > Tested-by: Saxena, Parth <[email protected]> > Acked-by: Saxena, Parth <[email protected]> > Acked-by: Brian Norris <[email protected]> > Signed-off-by: David Woodhouse <[email protected]> > Signed-off-by: Greg Kroah-Hartman <[email protected]> > > --- > drivers/mtd/nand/nand_base.c | 2 ++ > 1 file changed, 2 insertions(+) > > --- a/drivers/mtd/nand/nand_base.c > +++ b/drivers/mtd/nand/nand_base.c > @@ -2701,6 +2701,8 @@ static struct nand_flash_dev *nand_get_f > else > chip->chip_shift = ffs((unsigned)(chip->chipsize >> 32)) + 32 - > 1; > > + chip->badblockbits = 8; > + > /* Set the bad block position */ > chip->badblockpos = mtd->writesize > 512 ? > NAND_LARGE_BADBLOCK_POS : NAND_SMALL_BADBLOCK_POS; > > > Patches currently in longterm-queue-2.6.33 which might be from > [email protected] are > > _______________________________________________ > stable mailing list > [email protected] > http://linux.kernel.org/mailman/listinfo/stable _______________________________________________ stable mailing list [email protected] http://linux.kernel.org/mailman/listinfo/stable
