Hi Stefane,
Stefane Fermigier wrote:
Hi,
during the trip back from Amsterdam I spent some time reviewing the current
Stanbol code base, and fixing some issues.
Here are some remarks:
1. Stanbol doesn't build, it complains that
eu.iksproject:eu.iksproject.kres.shared.dependency.owlapi:jar:0.6-SNAPSHOT is
missing.
This is a major issue since it prevents building the whole stack, and putting
it under continuous integration.
2. Lots of files (almost 600) have tabs instead of (or mixed with) spaces. This
is bad behavior, because, depending on how your editor is set-up (tabs can be
2, 4 or 8 spaces long, depending on people choices), some people will get ugly
looking code.
I have a massive patch that expands all the tabs to 8 spaces. Will apply it
soon, unless there is some protests.
We prefer in general indentation by 2 spaces as blanks or tabs as it
makes better use of editor screens.
3. More generally we need to use a common formatting standard. The only way to
do so efficiently is to start with common formatter settings for Eclipse, and
apply it massively to the code base.
4. I have seen code duplicated from external projects:
- Base64.java: I know that it's not part of the Java standard Library, but
there is an Apache library for this, let's do this instead of forking their
code.
- DOMUtils.java: this has been forked from Sun Microsystems code, and as a license that
looks like a BSD license, except for this provision "You acknowledge that Software
is not designed, licensed or intended for use in the design, construction, operation or
maintenance of any nuclear facility." This makes it non open source, and this file
has to be removed. (Olivier tells me that Xstreams is a better alternative anyway).
Thanks for the hint to that very old Sun license text in that DOMUtils
class that passed unnoticed through many years of reuse and
modification. We will correct that.
Best regards,
Walter
That's it for today. We have also to change all the "eu.iksproject" to
"org.apache.stanbol" and to put the right license headers. I think it would also be
useful if everyone would sign their code in the header or in the Javadoc.
S.
--
Stefane Fermigier, Founder and Chairman, Nuxeo
Open Source, Java EE based, Enterprise Content Management (ECM)
http://www.nuxeo.com/ - +33 1 40 33 79 87 - http://twitter.com/sfermigier
Join the Nuxeo Group on LinkedIn: http://linkedin.com/groups?gid=43314
New Nuxeo release: http://nuxeo.com/dm54
"There's no such thing as can't. You always have a choice."
--
Dr. Walter Kasper
DFKI GmbH
Stuhlsatzenhausweg 3
D-66123 Saarbrücken
Tel.: +49-681-85775-5300 (*NEW NUMBER*)
Fax: +49-681-85775-5338 (*NEW NUMBER*)
Email: [email protected]
-------------------------------------------------------------
Deutsches Forschungszentrum fuer Kuenstliche Intelligenz GmbH
Firmensitz: Trippstadter Strasse 122, D-67663 Kaiserslautern
Geschaeftsfuehrung:
Prof. Dr. Dr. h.c. mult. Wolfgang Wahlster (Vorsitzender)
Dr. Walter Olthoff
Vorsitzender des Aufsichtsrats:
Prof. Dr. h.c. Hans A. Aukes
Amtsgericht Kaiserslautern, HRB 2313
-------------------------------------------------------------
