2010/12/12 Olivier Grisel <[email protected]> > 2010/12/12 Walter Kasper <[email protected]>: > > Hi Stefane, > > > > Stefane Fermigier wrote: > >> > >> Hi, > >> > >> during the trip back from Amsterdam I spent some time reviewing the > >> current Stanbol code base, and fixing some issues. > >> > >> Here are some remarks: > >> > >> 1. Stanbol doesn't build, it complains that > >> > eu.iksproject:eu.iksproject.kres.shared.dependency.owlapi:jar:0.6-SNAPSHOT > >> is missing. > >> > >> This is a major issue since it prevents building the whole stack, and > >> putting it under continuous integration. > >> > >> 2. Lots of files (almost 600) have tabs instead of (or mixed with) > spaces. > >> This is bad behavior, because, depending on how your editor is set-up > (tabs > >> can be 2, 4 or 8 spaces long, depending on people choices), some people > will > >> get ugly looking code. > >> > >> I have a massive patch that expands all the tabs to 8 spaces. Will apply > >> it soon, unless there is some protests. > > > > We prefer in general indentation by 2 spaces as blanks or tabs as it > makes > > better use of editor screens. > > I think we should adopt the same conventions as the related apache > projects: Lucene, Solr and Mahout all use the Sun official code > conventions with the exception of using 2 spaces indents instead of 4. > > http://www.oracle.com/technetwork/java/codeconv-138413.html
I agree > > > There is an eclipse code formatter (along with an unmaintained idea > version) here: > > > https://cwiki.apache.org/confluence/display/MAHOUT/How+To+Contribute#HowToContribute-HelpfulResources > > The whole wiki page HowToContribute on Mahout's wiki is worth a read > too (many practical details on how to make and apply a patch for > instance): > > https://cwiki.apache.org/confluence/display/MAHOUT/How+To+Contribute > > The same formatters from the Apache Lucene / Solr projects are available > here: > > http://wiki.apache.org/solr/HowToContribute?action=AttachFile > > If nobody has an objection I would like to do a batch reformat of the > existing stanbol codebase using this formatter next week > It sounds good to me. However before doing these changes I think there should be a wide consensus, maybe a vote? Tommaso
