On Dec 12, 2010, at 1:37 PM, Olivier Grisel wrote: > 2010/12/12 Walter Kasper <[email protected]>: >> Hi Stefane, >> >> Stefane Fermigier wrote: >>> >>> Hi, >>> >>> during the trip back from Amsterdam I spent some time reviewing the >>> current Stanbol code base, and fixing some issues. >>> >>> Here are some remarks: >>> >>> 1. Stanbol doesn't build, it complains that >>> eu.iksproject:eu.iksproject.kres.shared.dependency.owlapi:jar:0.6-SNAPSHOT >>> is missing. >>> >>> This is a major issue since it prevents building the whole stack, and >>> putting it under continuous integration. >>> >>> 2. Lots of files (almost 600) have tabs instead of (or mixed with) spaces. >>> This is bad behavior, because, depending on how your editor is set-up (tabs >>> can be 2, 4 or 8 spaces long, depending on people choices), some people will >>> get ugly looking code. >>> >>> I have a massive patch that expands all the tabs to 8 spaces. Will apply >>> it soon, unless there is some protests. >> >> We prefer in general indentation by 2 spaces as blanks or tabs as it makes >> better use of editor screens. > > I think we should adopt the same conventions as the related apache > projects: Lucene, Solr and Mahout all use the Sun official code > conventions with the exception of using 2 spaces indents instead of 4.
I do not agree on the 2 spaces per indent. I used to indent my code by 2 spaces 10 years ago, but nowadays, either because most of the Java code I read written by others is 4 spaces/indent, or because it's just intrinsically more readable, I tend to prefer 4 spaces/indent. > > http://www.oracle.com/technetwork/java/codeconv-138413.html > Also, the Sun code convention are OK, but written 14 years ago, and do not leverage the experience gained during these 14 years. S. -- Stefane Fermigier, Founder and Chairman, Nuxeo Open Source, Java EE based, Enterprise Content Management (ECM) http://www.nuxeo.com/ - +33 1 40 33 79 87 - http://twitter.com/sfermigier Join the Nuxeo Group on LinkedIn: http://linkedin.com/groups?gid=43314 New Nuxeo release: http://nuxeo.com/dm54 "There's no such thing as can't. You always have a choice."
