> -----Original Message----- > From: Vincent Legoll [mailto:[email protected]] > Sent: Sunday, November 01, 2015 1:07 AM > To: Keller, Jacob E > Cc: [email protected] > Subject: Re: [stgit-users] [PATCH 5/5] stgit: add support for --changeid to > add Change-Id tags > > I think you should tell what this is all about (and the rationale of > why (no commit hooks)) in the first patch of the series or do a cover > letter explaining the details. I was reading the series and found the > explanation of why only in the 5/5 patch desc... >
I didn't have a cover letter here and the first patch wasn't about the addition of the thing that could explain this, so I will send it with a cover letter in the next attempt. I tried to figure a way to just run the commit hooks inside stgit, but there is no easy way to do this, because of how the stack is implemented. I will explain this more in the cover letter. > BTW, is it defaulting to off for actual stgit users that don't need it > or new users ? It's defaulting to off because most users probably won't need it. > > On Fri, Oct 23, 2015 at 12:43 AM, Jacob Keller <[email protected]> > wrote: > > Also add a "changeid" configuration, (overridden by the command line > > option "--no-changeid") which will automatically add a new "Change-Id:" > > line to commits. This is useful for when working with Gerrit, as the > > commit hook is not run during stgit workflow. > [...] > > +++ b/stgit/argparse.py > > @@ -113,6 +113,12 @@ def callback(option, opt_str, value, parser, > sign_str): > > 'Cannot give more than one of --ack, --sign, --review') > > parser.values.sign_str = sign_str > > return [ > > + opt('--changeid', action = 'store_true', dest='changeid', > > + short = 'Add a "Change-Id:" line', long = """ > > + Add a "Change-Id:" to the end of the patch."""), > > + opt('--no-changeid', action = 'store_false', dest='changeid', > > + short = 'Do not add a "Change-Id:" line', long = """ > > + Do not add a "Change-Id:" to the end of the patch."""), > > I think explaining that it's for gerrit use there could be useful for the > unknowing user wondering what that could be for. > I could do that yes. > Will the man page automagically get the new option description ? > I believe stgit generates man pages from the python doc strings..? I know the --help does, but I can make sure the manpage does as well. > You may want to add a web link pointing to gerrit page explaining > the whole thing there too... Yes. > > -- > Vincent Legoll _______________________________________________ stgit-users mailing list [email protected] https://mail.gna.org/listinfo/stgit-users
