Hi, >> maybe just put it after the last found tag or at the end if no tag is found.
The term "tag" is such a poor choice here... I realize it's not your choice, but it does not seem universal either: is there some alternative term you could use in the code? > It traditionally goes at the top. This is where gerrit looks for it, and I'm > not entirely sure that it will work properly if it goes elsewhere. https://gerrit-review.googlesource.com/Documentation/user-changeid.html "To be picked up by Gerrit, a Change-Id line must be in the footer (last paragraph) of a commit message" This documentation is confirmed by experience: it does not matter where exactly in the last paragraph as long as it's there. By the way this URL could make a good addition if you're looking for one. > I am attempting to encode the same behavior as the gerrit git-commit hook. As a general comment: this series looks to me like a fairly large change and number of lines for merely duplicating a relatively simple and not universally used feature... wouldn't running a --run-commit-hook option offer much more with less code? > The block of tags comes after the description and ideally should have a > complete blank line above them ("\n\n", basically) The structure is not always that simple, see some real-world examples here: https://chromium-review.googlesource.com/302513 https://chromium-review.googlesource.com/298212 Marc _______________________________________________ stgit-users mailing list [email protected] https://mail.gna.org/listinfo/stgit-users
