> -----Original Message-----
> From: Vincent Legoll [mailto:[email protected]]
> Sent: Sunday, November 01, 2015 1:12 AM
> To: Keller, Jacob E
> Cc: [email protected]
> Subject: Re: [stgit-users] [PATCH 1/5] stgit: separate out tags for splitting
> description
>
> Hello,
>
> On Fri, Oct 23, 2015 at 12:43 AM, Jacob Keller <[email protected]>
> wrote:
> > Still assumes all tags appear at the bottom without extra spaces.
>
> maybe just put it after the last found tag or at the end if no tag is found.
>
It traditionally goes at the top. This is where gerrit looks for it, and I'm
not entirely sure that it will work properly if it goes elsewhere. I am
attempting to encode the same behavior as the gerrit git-commit hook.
> Why not check for tag at the beginning of line (with "^") to alleviate the
> need for "\n" being present ? that sohuld cover more cases.
>
Because we want to ensure that we don't treat the first line of a commit
message as a tag. The block of tags comes after the description and ideally
should have a complete blank line above them ("\n\n", basically)
Since we're checking for explicit types of tags, though, maybe it does make
sense to use "^" since it is unlikely someone makes their commit message start
with a tag. However tag-like things "[a-zA-Z-]+:" type tags are often used on
the first line. But essentially, the extra cases covered by ^ vs \n are ones we
don't actually want.
Regards,
Jake
_______________________________________________
stgit-users mailing list
[email protected]
https://mail.gna.org/listinfo/stgit-users
