OK, this seems to be the consensus opinion so we'll start getting 
transitioned to providing open code reviews.  The first one should be 
this week sometime.

-Peter

Nigel Smith wrote:
> Hi Peter
> Yes, lets try the 'code review' format, so we can
> take a first look at the iSer source code.
> Presumably this will compare the current code,
> with a suitably older version of the code,
> to highlight the recent changes.
>
> Using OpenGrok has been a good way to view
> the source code for the old iscsi target:
> http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/cmd/iscsi/iscsitgtd/
>
> And it has been really useful to be able to see 
> the 'history' of the code, which is hyper linked 
> with the bugs database. For example:
> http://src.opensolaris.org/source/history/onnv/onnv-gate/usr/src/cmd/iscsi/iscsitgtd/t10_sam.c
>
> But the old target was in the ONNV source directory.
> The iscsi initiator is in the NWSC source directory.
> http://src.opensolaris.org/source/xref/nwsc/src/sun_nws/iscsi/src/
> and you don't get any history with that :-(
>
> I guess ComStar & iSer will eventually be in the NWSC 
> source directory. So presumably no history.
>
> Ok, I had better get subscribed to the iSer dev maillist.
> I don't suppose there is going to be a 'jive' web interface
> to this list.  For all its fault, I do find Jive useful
> for posting, now I know how to work around it's faults,
> and live with it's problems.
> Best Regards
> Nigel Smith
>  
>  
> This message posted from opensolaris.org
> _______________________________________________
> storage-discuss mailing list
> [email protected]
> http://mail.opensolaris.org/mailman/listinfo/storage-discuss
>
>   

_______________________________________________
storage-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/storage-discuss

Reply via email to