>>>>> "Martin" == Martin Cooper <[EMAIL PROTECTED]> writes:

    >> In several tag classes in the HTML library, I have some 
    >> attribute evaluations
    >> commented out, as I've discovered that these are attributes 
    >> which the HTML 4.01
    >> spec defines, but which are not covered in the current Struts 
    >> tag, either
    >> because their TLD doesn't specify them, or the Struts tag 
    >> doesn't properly emit
    >> them.  I've noticed some of these have had bugs reported 
    >> against them (some by
    >> me), but probably not all.  One thing I want to do in the 
    >> very near future is
    >> make sure all of these are logged (and maybe even fix them :) ).

    Martin> Is there an easy way to find these comments? A Bugzilla report listing
    Martin> what's missing would be very helpful. I've wanted to get this cleaned up,
    Martin> but haven't had the time to go through and check all the tags myself.

Note that I've finished examining this from the POV of the Struts-EL tags.  I
ended up de-commenting several attribute handlers in the EL tags, as I found
the base tags were correctly handling these attributes (and the spec says they
should be).  I also removed some commented-out attribute handlers, as I
verified that the spec shows they should NOT be handled, and the base Struts
tags don't support them.

I also submitted two bugs for the Struts tags for missing attributes which
should be handled (RadioTag and OptionTag).  As those bugs are still pending, I
still have those attribute handlers in the EL tags commented out.

I have not gone through the base Struts tags to see if there are any attributes
they should be handling, but are not.  I don't plan on doing this, as that
would be too mentally punishing :) .

-- 
===================================================================
David M. Karr          ; Java/J2EE/XML/Unix/C++
[EMAIL PROTECTED]


--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to