CCing the mailing list. On 4 May 2015 at 02:23, Gehad <[email protected]> wrote: > On 05/02/2015 07:14 PM, Lubomir I. Ivanov wrote: >> On 29 April 2015 at 02:00, Gehad <[email protected]> wrote: >>> >>> This is my fork: >>> https://github.com/Gehadelrobey/subsurface >>> I'll push to 'custom-print' branch and rebase it with master regularly. >>> >> >> hello Gehad, >> here are some comments on the two commits that i see. >> >> https://github.com/Gehadelrobey/subsurface/commit/781f0f98167096c045df1426667078962b96f101 >> >> CSS coding style related >> >> .innerContainer { >> height: 85%; >> ... >> } >> >> note that: >> - the opening brace is on the same line as the class name >> - "height : ..." should be without space after "height" and before >> ":". space only after ":". >> > > Fixed and pushed to the branch.
thanks, looks good. > >> https://github.com/Gehadelrobey/subsurface/commit/af2376ff2e9277d938d29c95c3999443f8023c56 >> >> i need to see if if this works from me (on win32): >> find_package(Grantlee5) >> >> for instance, it finds marble using find_package, but the resulted >> variables were bogus if i recall correctly. >> >> even if AFAIK both libraries don't use pkg-config we may have to add >> the optional: >> GRANTLEE_FROM_PKGCONFIG >> MARBLE_FROM_PKGCONFIG >> > > I changed the cmake file a little bit. > > -find_package(Grantlee5) > -set(GRANTLEE_LIBRARIES Grantlee5::Templates) > +if(GRANTLEE_FROM_PKGCONFIG) > + pkg_config_library(LIBGRANTLEE libgrantlee-templates5 REQUIRED) > + set(GRANTLEE_LIBRARIES "") > +else() > + find_package(Grantlee5) > + set(GRANTLEE_LIBRARIES Grantlee5::Templates) > +endif() > > I installed libgrantlee-dev but couldn't find the package with > pkg-config, So I didn't succeed to link subsurface to libgrantlee5. > > that's probably because marble and grantlee AFAIK don't use pkg-config. like i said: > unlike cmake, qmake allowed "PKGCONFIG += libmarble", which was very handy. i need to figure a way how to approach the cmake issue before i continue reviewing, as i simply can't compile ATM. then i also need to look into the rest of the patches that you have pushed. lubomir -- _______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
