> On Feb 20, 2016, at 9:09 PM, Rick Walsh <[email protected]> wrote: > > 50F to 50C. That's annoying. One is a bit nippy, the other is decidedly too > > warm... > > > > Let me stare at that code for a moment... odd, at first glance the code > > looks like it should work. If the text you entered contains "C" (or > > actually, QObject::tr("C") - are you running this in a locale where that > > might be an issue?) then we use C_to_mkelvin(number)... and since we don't > > have an en_AU translation to begin with and even in that "C" should > > translate into "C"... hmmm... > > > > I just tried again. This time even colder/not as hot. 40°F works brrr > (converted to 4.4°C), but 40F, 40f and 40°f all just take the number as 40°C. > I think we should tolerate lazy typing, permitting lower case and not > requiring the degree sign. > >
Definitely. I can't reproduce the issue here, though. But I'll play with the test to make it more relaxed. I did reproduce the negative depth and am investigating validators to figure out how to avoid that /D
_______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
