Hello Willem, Am 04.01.2018 um 07:13 schrieb Willem Ferguson: > >> Can you do a Github PR for this? For me it's much easier to discuss >> it there and also to pull and test it :-) >> > Done. The title of the PR is a bit obscure, not intended. > Kind regards, > willem Honestly the whole PR looks a little bit "obscure" or in other words - there went s.th. wrong ;-)
Maybe the way you did the PR (file upload?!) is not the best one. But even if it works there are two other mistakes beside the PR title: - The file has to go in /core/plannernots.c - The commit title is also wrong Maybe better to do the PR in the way of pushing the change to your own GitHub repo and then do the PR from there. I'm also no real pro but my flow usually looks like: - Change is available in my local git repo in a branch I call "mystable" including 1-n commits - Local branch master is up to date - git checkout -b feature_whatever - git rebase -i master Remove everything which is NOT part of the change - git push https://github.com/sfuchs79/subsurface.git feature_whatever - Then do the PR on GitHub Best regards Stefan -- Stefan Fuchs E-Mail: [email protected] <mailto:[email protected]>
_______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
