On 07/05/2007 09:06 AM Alexandru Stanoi wrote: > Tobias Schlitt wrote: >> On 07/05/2007 08:54 AM Alexandru Stanoi wrote: >>> Tobias Schlitt wrote: >>>> On 07/04/2007 02:52 PM Alexandru Stanoi wrote: >>>>> Log: >>>>> - Move options classes to more logical directories. >>>>> Added: >>>>> trunk/Mail/src/parser/parser_options.php >>>>> - copied unchanged from r5680, >>>>> trunk/Mail/src/options/parser_options.php >>>>> trunk/Mail/src/transports/imap/imap_options.php >>>>> - copied unchanged from r5680, >>>>> trunk/Mail/src/options/imap_options.php >>>>> trunk/Mail/src/transports/pop3/pop3_options.php >>>>> - copied unchanged from r5680, >>>>> trunk/Mail/src/options/pop3_options.php >>>>> trunk/Mail/src/transports/smtp/smtp_options.php >>>>> - copied unchanged from r5680, >>>>> trunk/Mail/src/options/smtp_options.php >>>>> trunk/Mail/src/transports/transport_options.php >>>>> Removed: >>>>> trunk/Mail/src/options/ >>>> Is this a new way for storing option classes? All other components are >>>> keeping these classes in options/. Why to change that?
>>> I just like it better this way. And it seems more organized to have >>> all related classes in one folder. >> If that is your personal taste, its ok for me, but we should keep it >> consistent in all components. Otherwise it is hard for other developers >> to dig into the components you maintain. Therefore: Please revert this >> patch! > Maybe the others have another opinion? If all votes are against me then > I will revert. Maybe you should do it the other way around next time: First propose a structural change and then commit it, if everybody agrees? > And nobody noticed that the same is in Authentication and SignalSlot? I really did not notice it in Authentication, which is my fault. SignalSlot only supports 1 option class, which is stored options.php in the source root. I asume this is quite intuitive in respect to the usual options/ directory. Anyway, you are right, that this does not correspond 100% to the other components. Regards, Toby -- Mit freundlichen Grüßen / Med vennlig hilsen / With kind regards Tobias Schlitt (GPG: 0xC462BC14) eZ Components Developer [EMAIL PROTECTED] | eZ Systems AS | ez.no -- svn-components mailing list [email protected] http://lists.ez.no/mailman/listinfo/svn-components
