On 11/10/15 16:03, Randall Stewart wrote:
And I disagree here Hans

You don’t need that and it just adds more into the
callout system that is not needed.

Hi,

It also makes debugging more easy, that you can see the last function call and argument. I.E. You should not have to clear the drain function pointer before calling the drain function.

Something else. Maybe you should bump the FreeBSD version, because callout_stop() is a macro, and you've changed its API by adding another argument to _callout_stop_safe(), to force a recompilation of KLD's. Else garbage will be passed into "drain" ...

--HPS
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Reply via email to