On 11/13/2015 1:00 PM, Randall Stewart wrote: > Bryan: > > This looks like a decent thing to do.. > > Still wondering why changing the callout.h header file would not have caused > things to recompile to pick up the new argument.. > > We can do it this way though it looks fine. > > You want to commit it or I?
Well your change is totally safe for compiling. It's just not KBI backwards compat for older modules. This is not typically a problem but I think in this case it is worth doing to avoid random data coming into the 'drain' argument if loading an older module. I'll do a test build and commit it. Perhaps this is what was leading to Alexander's panics. I haven't analyzed the return value issue at all. -- Regards, Bryan Drewery
signature.asc
Description: OpenPGP digital signature
