On 3/7/18 10:40 AM, Sergey Bylokhov wrote:
On 07/03/2018 10:21, semyon.sadet...@oracle.com wrote:
That's not ok, since we change a behavior without discussion that
the benefits of change outweigh the disadvantages, when we
implemented some unrelated fix.
That's not true. You may find the discussion in the current thread.
Fill free to provide your arguments to it.
I found nothing related to the behavior, only some conclusion about
possible performance difference.
So you agree?
You always should check for null return if the spec does not say that
null is never returned. In this specific case if null check is absent
the NPE will be thrown in the user code instead of JDK code, so there is
Returning null is better than throwing NPE especially in the case
when NPE doesn't correspond to the spec. Krishna kindly agreed to fix
both issues at once. I didn't get what is the problem?
It is an improvement. NPE is not expected result according to the
toDisplayString() method spec.
It also changed result of toDisplayString(), previously it did not
returned null. I think .01 is better and simpler.
Nope, if the method start to return null means that all its usage
should be checked for null return value.
As I said it is better to use version .01 which fixed the problem w/o
Thanks for your advice. Try to provide more arguments next time.