I am not sure that the test will properly cover the fix. I mean the test should cover the Windows L&F and maybe other L&F, but when I have run the test on macOS, I simply could not find the "the \"Look in\" combobox's popup".
On 3/4/20 2:43 am, Bhawesh Choudhary wrote:
Hi, Please review this fix, JBS: https://bugs.openjdk.java.net/browse/JDK-8233584 Webrev: http://cr.openjdk.java.net/~psadhukhan/8233584/webrev/ Issue: In Windows LookAndFeel, When navigating Combobox's list of JFileChooser via keys, the contents of JFileChooser changes. Fix: Set flag "JComboBox.isTableCellEditor" to True which prohibits JCombobox from sending selection change event when JCombobox's list selection change happens via keys. Verification: Tested the fix with JFileChooser with WindowsLookAndFeelEnabled as well as BasicLookAndFeel with keys navigation. also added a test case to verify the same. Did not find any misbehavior with the fix. Regards Bhawesh
-- Best regards, Sergey.
