Looks fine.
On 3/31/20 2:16 am, Bhawesh Choudhary wrote:
Hi,
Please find updated Webrev as per suggestions [Test case updates for
WindowsLookAndFeel]
JBS: https://bugs.openjdk.java.net/browse/JDK-8233584
Webrev: http://cr.openjdk.java.net/~psadhukhan/8233584/webrev.1/
-Bhawesh
On 3/13/2020 12:10 PM, Bhawesh Choudhary wrote:
Hi,
Please find updated Webrev as per suggestions [Test name update and Code
formatting]
JBS: https://bugs.openjdk.java.net/browse/JDK-8233584
Webrev: http://cr.openjdk.java.net/~psadhukhan/8233584/webrev.01/
-Bhawesh
On 3/4/2020 4:13 PM, Bhawesh Choudhary wrote:
Hi,
Please review this fix,
JBS: https://bugs.openjdk.java.net/browse/JDK-8233584
Webrev: http://cr.openjdk.java.net/~psadhukhan/8233584/webrev/
Issue:
In Windows LookAndFeel, When navigating Combobox's list of JFileChooser via
keys, the contents of JFileChooser changes.
Fix:
Set flag "JComboBox.isTableCellEditor" to True which prohibits JCombobox from
sending selection change event when JCombobox's list selection change happens via keys.
Verification:
Tested the fix with JFileChooser with WindowsLookAndFeelEnabled as well as
BasicLookAndFeel with keys navigation. also added a test case to verify the
same.
Did not find any misbehavior with the fix.
Regards
Bhawesh
--
Best regards, Sergey.
