On Thu, 24 Sep 2020 06:00:25 GMT, Tejpal Rebari <treb...@openjdk.org> wrote:
>> The test test/jdk/javax/swing/JPopupMenu/4966112/bug4966112.java fails for
>> Mac OS X
>> with the error message Popup was not shown on FileChooser.
>>
>> Popup doesn't appear for JFileChooser in MAC OS X platform so
>> skipping this test for Mac OS X.
>
> Tejpal Rebari has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Testing filechooser on aqua at a different place, where context popup works
test/jdk/javax/swing/JPopupMenu/4966112/bug4966112.java line 156:
> 154: Point p = c.getLocationOnScreen();
> 155: Dimension size = c.getSize();
> 156: if (isAquaFileChooser){
nit pick ){ -> ) { - ie add a space.
test/jdk/javax/swing/JPopupMenu/4966112/bug4966112.java line 105:
> 103: if (System.getProperty("os.name").startsWith("Mac")) {
> 104: isAquaFileChooser = true;
> 105: } else {
nitpick: it depends on the current L&F, doesn't it ?
-------------
PR: https://git.openjdk.java.net/jdk/pull/204
