On Wed, 4 Aug 2021 21:19:04 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> I think we should give this fix a chance...sInce this is solving 2 >> long-standing issue where setBackground() contract is not honoured plus >> causing no regression to existing tests. >> If we do find any testcase with "shape" in future from open community or any >> other related testcase being failed for this fix, we can always work on it >> (or at the least roll back this) > > It looks the fix doesn't work or alternatively it works in an unexpected way. > > Both JEditorPane and JTextPane used to have white background but now, with > these changes, their background is the same of the panel below. It's probably > know what we want. The last time this code was touched we get a regression https://bugs.openjdk.java.net/browse/JDK-8266510 which was not found by any tests. JCK cannot found them since this is L&F dependent. And regression tests do not have related tests because we had never bugs here, it worked this way from the beginning. So it will be good to understand why these tags prevent the color change, how the shape tags are used, instead of some unknown changes here and there. ------------- PR: https://git.openjdk.java.net/jdk/pull/4930
