On Mon, 9 Aug 2021 13:01:17 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
> > > > > The tests are nearly the same: the only difference is the component being > > > tested. I suggest merging the two tests into one test which tests both > > > components one after another. > > > > > > I would rather have as separate test as the fix is in 2 different > > component, I could have raised separate PRs as fix area is different > > although fix seems to be same..and I don't see it as anyhting other than > > test optimization.. > > If you absolutely cannot approve without test merged, then please let me > > know. I would try to do > > I'm for fixing these two issues under one PR. The fix is basically the same, > so it makes it easier to review and track changes later. > > Yes, it's kind of a test optimisation. Yet the tests are similar in nature, > they exercise the same behaviour in two different components. It just makes > sense to re-use the code. If a fix is necessary to one test, it is necessary > for the other — same idea why avoiding duplicate code is good. > > It's not a show-stopper though if everyone agrees it's better to have two > different tests. OK..Not a problem. Merged... ------------- PR: https://git.openjdk.java.net/jdk/pull/4930
