On Wed, 4 Aug 2021 23:06:35 GMT, Sergey Bylokhov <s...@openjdk.org> wrote:

>> It looks the fix doesn't work or alternatively it works in an unexpected way.
>> 
>> Both JEditorPane and JTextPane used to have white background but now, with 
>> these changes, their background is the same of the panel below. It's 
>> probably know what we want.
>
> The last time this code was touched we get a regression 
> https://bugs.openjdk.java.net/browse/JDK-8266510 which was not found by any 
> tests. JCK cannot found them since this is L&F dependent. And regression 
> tests do not have related tests because we had never bugs here, it worked 
> this way from the beginning.
> 
> So it will be good to understand why these tags prevent the color change, how 
> the shape tags are used, instead of some unknown changes here and there.

JDK-8266510 regression was found by SwingSet2 so it is wrong to say it was not 
found by any test, maybe it was not verified during fix of JDK-8249674. For 
this, all existing test is run.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4930

Reply via email to