Quick note: I remember scanning the patch originally sent seeing a 'new' without an obvious delete. Please be sure to check for this. I may be wrong; it was a quick observation.
I do appreciate and plan to incorporate Matthew's suggestions into svn head. I believe I still may research clucene and see if we can use our UTF-16 or 32 conversion routines so we won't need to allocate 1 meg of static buffer. Considering all the comments recently about bc and index versioning as well. We need to release a 1.6.1 soon and it should contain most of these things. -Troy. Jonathan Marsden wrote: > I have split out three specific patches from Matthew's single larger > patch, and tested what happens when I incorporate them in our sword > packages. They all test out fine for me. Each one fixes a clearly > present bug in the current packaged code. > > The three patch files are available for download at: > > http://crosswire.org/~jmarsden/16_larger_search_buffer.diff > http://crosswire.org/~jmarsden/17_no_stop_words.diff > http://crosswire.org/~jmarsden/18_check_index_dir_is_writeable.diff > > Although they were made against the sword 1.6.0 tarball code by quilt, > they apply cleanly against SWORD svn head (use patch -p1 <filename.diff > to apply them by hand). I'd be happy to see them accepted into the > official SWORD codebase. > > I did this work because I'm seriously thinking about trying for an FFe, > so we can get these, plus a packaging change to re-enable module > encryption and decryption (!), into Karmic. > > Anyone with objections, or anyone with suggested additional bugfixes > that should go into such a package update, please speak up. > > Jonathan > > > _______________________________________________ > sword-devel mailing list: sword-devel@crosswire.org > http://www.crosswire.org/mailman/listinfo/sword-devel > Instructions to unsubscribe/change your settings at above page _______________________________________________ sword-devel mailing list: sword-devel@crosswire.org http://www.crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page