Thank you Fabien!

Sent from my Nexus One
On Sep 28, 2010 2:41 AM, "Fabien Potencier" <
fabien.potenc...@symfony-project.com> wrote:
> I have committed the change:
>
>
http://github.com/fabpot/symfony/commit/a6dc10c31ae78744ecd513263270f309651c42b0
>
> And here is the commit message:
>
> "
> changed templating name notation
>
> Old notation: bundle:section:name.format:renderer (where both format and
> renderer are optional)
>
> New notation: bundle:section:name.format.renderer (where only format is
> optional)
>
> Valid new template names: Blog:Post:index.php, Blog:Post:index.xml.php
>
> The new notation is more explicit and put all templating engines on the
> same level (there is no more the concept of a "default" templating
engine).
>
> Even if the notation changed, the semantic has not. So, the logical
> template name for the above examples is still 'index'. So, if you use a
> database loader for instance, the template name is 'index' and
> everything else are options.
>
> Upgrading current applications can be easily done by appending .php to
> each existing template name reference (in both controllers and
> templates), and changing :twig to .twig for Twig templates (for twig
> templates, you should also add .twig within templates themselves when
> referencing another Twig templates).
> "
>
> Fabien
>
> --
> Fabien Potencier
> Sensio CEO - symfony lead developer
> sensiolabs.com | symfony-project.org | fabien.potencier.org
> Tél: +33 1 40 99 80 80
>
> On 9/27/10 1:48 PM, Kris Wallsmith wrote:
>> +1 for requiring the engine in the string reference and using dots
>> instead of colons to mark (optional) format and (required) engine.
>>
>> --
>>
>> *Kris Wallsmith* | Release Manager
>> kris.wallsm...@symfony-project.com
>> <mailto:kris.wallsm...@symfony-project.com>
>> Portland, Oregon USA
>>
>> http://twitter.com/kriswallsmith
>>
>> On Sep 27, 2010, at 4:03 AM, Matthias Nothhaft wrote:
>>
>>> On Sep 25, 7:43 am, Fabien Potencier <fabien.potenc...@symfony-
>>> project.com <http://project.com>> wrote:
>>>> Here is another suggestion: what about removing the "default"
templating
>>>> engine. What about making the templating engine part of the template
>>>> name mandatory. That way we are always explicit and there is no default
>>>> per se (technically -- of course, the documentation part is different):
>>>>
>>>> HelloBundle:Hello:index:php
>>>> HelloBundle:Hello:index:twig
>>>>
>>>> HelloBundle:Hello:index.xml:php
>>>> HelloBundle:Hello:index.xml:twig
>>>>
>>>> We can probably find a better naming convention. What about this:
>>>>
>>>> HelloBundle:Hello:index.php
>>>> HelloBundle:Hello:index.twig
>>>>
>>>> HelloBundle:Hello:index.xml.php
>>>> HelloBundle:Hello:index.xml.twig
>>>>
>>>> That way, when you are using the filesystem loader (and this is the
case
>>>> 99% of the time), the last part is just the file name.
>>>
>>> +1 for being explicit and for "last part = filename". index:twig /
>>> index:php is just confusing.
>>>
>>> But there is still the problem with the docs.. ;-)
>>>
>>> regards,
>>> Matthias
>>>
>>> --
>>> If you want to report a vulnerability issue on symfony, please send it
>>> to security at symfony-project.com <http://symfony-project.com>
>>>
>>> You received this message because you are subscribed to the Google
>>> Groups "symfony developers" group.
>>> To post to this group, send email to symfony-devs@googlegroups.com
>>> <mailto:symfony-devs@googlegroups.com>
>>> To unsubscribe from this group, send email to
>>> symfony-devs+unsubscr...@googlegroups.com<symfony-devs%2bunsubscr...@googlegroups.com>
>>> <mailto:symfony-devs+unsubscr...@googlegroups.com<symfony-devs%2bunsubscr...@googlegroups.com>
>
>>> For more options, visit this group at
>>> http://groups.google.com/group/symfony-devs?hl=en
>>
>> --
>> If you want to report a vulnerability issue on symfony, please send it
>> to security at symfony-project.com
>>
>> You received this message because you are subscribed to the Google
>> Groups "symfony developers" group.
>> To post to this group, send email to symfony-devs@googlegroups.com
>> To unsubscribe from this group, send email to
>> symfony-devs+unsubscr...@googlegroups.com<symfony-devs%2bunsubscr...@googlegroups.com>
>> For more options, visit this group at
>> http://groups.google.com/group/symfony-devs?hl=en
>
> --
> If you want to report a vulnerability issue on symfony, please send it to
security at symfony-project.com
>
> You received this message because you are subscribed to the Google
> Groups "symfony developers" group.
> To post to this group, send email to symfony-devs@googlegroups.com
> To unsubscribe from this group, send email to
> symfony-devs+unsubscr...@googlegroups.com<symfony-devs%2bunsubscr...@googlegroups.com>
> For more options, visit this group at
> http://groups.google.com/group/symfony-devs?hl=en

-- 
If you want to report a vulnerability issue on symfony, please send it to 
security at symfony-project.com

You received this message because you are subscribed to the Google
Groups "symfony developers" group.
To post to this group, send email to symfony-devs@googlegroups.com
To unsubscribe from this group, send email to
symfony-devs+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/symfony-devs?hl=en

Reply via email to