Did you do any investigation what method names/log levels other frameworks use for logging? The current ones are not only close to syslog, or Zend, but also close to log4j, to Logbook (after which you have designed Monolog), and I'll probably find more if I search further.
I feel that this change is a bit rushed at this point, and IMO it should only be made if there is a real benefit, or if the current system is broken which I fail to see right now. Why would we want to invent our own conventions now? To address any possible confusion what the priorities mean, this mainly seems like a documentation issue to me. Kind regards, Johannes On Wed, Apr 20, 2011 at 11:09 PM, Jordi Boggiano <[email protected]> wrote: > Heya, > > I would like to adjust the LoggerInterface before it's too late. Fabien > told me he didn't mind, but I'd like to ask everyone before doing the > patch because it's gonna take a bit of time to double check I don't mess > things up. > > Basically I would like to remove all the useless (imo) log priorities, > and keep the 4 that are in Monolog (debug, info, warning, error), > because they are more than enough and that will save you time since you > don't have to wonder which one is the most appropriate. > > I would also like to match with Monolog's method, because I think they > are more grammatically/stylistically correct compared to the rest of the > framework, that means: > > debug() => addDebug() > info() => addInfo() > warn() => addWarning() > err() => addError() > > The current ones are based on ZF Log which is based on syslog levels, > which really don't make much sense to most PHP devs. The Logger is > basically a container, to which you add record, so the add* notation > makes sense and matches all the other "containers" we have in the > framework. > > Any opposition (with arguments please)? > > Cheers > > -- > Jordi Boggiano > @seldaek :: http://seld.be/ > > -- > If you want to report a vulnerability issue on symfony, please send it to > security at symfony-project.com > > You received this message because you are subscribed to the Google > Groups "symfony developers" group. > To post to this group, send email to [email protected] > To unsubscribe from this group, send email to > [email protected] > For more options, visit this group at > http://groups.google.com/group/symfony-devs?hl=en > -- If you want to report a vulnerability issue on symfony, please send it to security at symfony-project.com You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en
