On 21.04.2011 11:52, Johannes Schmitt wrote: > > But there could be getInfo(), getDebug() etc, so I think adding > "add" is indeed a good idea and consistent with our naming conventions. > > > Correct me if I'm wrong, but these methods could never be used to "get" > individual log messages? There can only be methods like > getAllDebugMessages etc.
That's right, and they belong to custom handlers rather than the Logger class itself anyway. This is not a valid point. To me the problem is just that it's bad naming, most (I'm sure there are a few exception so I won't say all) method names are verbs like render() or get() or locate() etc. What does crit() mean? or info()? debug() and warn() are even more confusing, because they don't debug and don't warn anything, they just add a message to the log. add*() makes much more sense to me. And again I'd rather have consistency with the rest of the framework than consistency with a nix OS-level API. Cheers -- Jordi Boggiano @seldaek :: http://seld.be/ -- If you want to report a vulnerability issue on symfony, please send it to security at symfony-project.com You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en
