On 21.04.2011, at 11:28, Johannes Schmitt wrote: > Maybe we can view these two things separately as they have not really > anything to do with each other. > > 1) Removing some log priorities > > I guess that isn't too bad, but nonetheless I'd like to see some reasoning > why you want to drop individual log levels. Otherwise it's just based on some > feeling, and imo that's not good enough for potentially breaking third party > code at this point. We are in a stabilizing phase so these BC breaks should > already be kept to a minimum. Fabien has turned down things for this reason > before, so it just seems consequential that we need to discuss this a bit > more thoroughly before making this change.
What are the ones you want to remove Jordi? But overall I think the ones you mentioned to leave in seem sufficient to me. > 2) Changing method names > > I don't think that it makes sense to prefix methods with "add". First, > logging is always about adding. There is no reason to delete, or edit a log > entry; there will never be methods like "removeDebug", "editDebug", etc. So, > the prefix is not necessary, it's always implied if you call such a method. > Second, this would be a departure from the syntax that many other libraries > have for no good reason. But there could be getInfo(), getDebug() etc, so I think adding "add" is indeed a good idea and consistent with our naming conventions. regards, Lukas Kahwe Smith [email protected] -- If you want to report a vulnerability issue on symfony, please send it to security at symfony-project.com You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en
