-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 +1 for following naming conventions and call the methods to add log messages addXXX()
as you can choose your own logger with as many levels as you want for your application anyway, it seems a good idea to me to keep the required number as low as possible. it helps keeping the code consistent. the logbook list (without info) sounds reasonable to me. this would leave a distinction between error and critical which might be helpful to alert actively on critical stuff... but i would be ok too with just the 4 levels jordi proposed. cheers, david Am 21.04.2011 18:21, schrieb Georg: > > > Am 21.04.2011 12:47, schrieb Johannes Schmitt: >> For the method names, I think they need to be viewed in combination with >> the variable they are called on, e.g. >> >> $logger->log() vs. $logger->addRecord() >> $logger->debug() vs. $logger->addDebug() >> etc. >> > > Personally I would prefer > > $log->addWarning() > > over > > $log->warning() > > because I feel the object I am using is a log and not a logger (even if > it is the logger which is doing the work) > - -- Liip AG // Agile Web Development // T +41 26 422 25 11 CH-1700 Fribourg // PGP 0xA581808B // www.liip.ch -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk21V5sACgkQqBnXnqWBgIsg4QCbBhpSeQ4J1qjt/pJ8YjlNrCj4 i/AAoLpbCSE3IAwZ7+uqZ3ys0ns/MUzx =T2O4 -----END PGP SIGNATURE----- -- If you want to report a vulnerability issue on symfony, please send it to security at symfony-project.com You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en
