It's not a definition of "atomic" though. A 50,000-line pull request can
have a complete test suite and pass all tests, yet I'd hardly consider such
a thing atomic.
How about "the smallest production ready"?
I think that's what Aaron meant.
Yes, and that's a useful definition for "atomic", but that would mean
5-line pull requests.
Hey, for docstrings, it would mean every changed sentence needs to be
broken into a separate pull request, since it's still production-ready.
So in that case, "atomic" isn't the right criterion.
(Maybe I'm wrong and we should really be doing five-line pull requests
as long as they are atomic. I'm not experienced enough with git to say
for sure whether that's idiocy or actually the best approach. Maybe
somebody should try this out.)
--
You received this message because you are subscribed to the Google Groups
"sympy" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sympy?hl=en.
